Messages in this thread | | | Date | Fri, 22 Oct 2021 11:28:12 -0400 | From | Bryan Brattlof <> | Subject | Re: [PATCH v3 1/4] staging: rtl8723bs: core: Remove true and false comparison |
| |
Hi Kushal,
On this day, October 22, 2021, thus sayeth Kushal Kothari: > Remove comparison to true and false in if statement. > Issue found with checkpatch.pl. > CHECK: Using comparison to true is error prone > CHECK: Using comparison to false is error prone > > Signed-off-by: Kushal Kothari <kushalkothari285@gmail.com> > > Changes in v3: Enclose the version number inside the square bracket. > Changes in v2: Unnecessary parantheses handled in *v2 staging: rtl8723bs: core: Remove unnecessary parentheses*
You may want to move these version notes below the cutoff so they won't be included in the body of your commit message.
> ---
[here]
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c > index 2624e994513f..acd4e8b1fad5 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c > +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c > @@ -371,7 +371,7 @@ void rtw_free_cmd_obj(struct cmd_obj *pcmd)
~Bryan
| |