Messages in this thread | | | Date | Fri, 22 Oct 2021 18:13:04 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v6] tty: Fix the keyboard led light display problem |
| |
On Thu, Oct 21, 2021 at 10:05:11AM +0800, lianzhi chang wrote: > Switching from the desktop environment to the tty environment, > the state of the keyboard led lights and the state of the keyboard > lock are inconsistent. This is because the attribute kb->kbdmode > of the tty bound in the desktop environment (xorg) is set to > VC_OFF, which causes the ledstate and kb->ledflagstate > values of the bound tty to always be 0, which causes the switch > from the desktop When to the tty environment, the LED light > status is inconsistent with the keyboard lock status.
...
> + unsigned long leds; > + > + leds = (unsigned long)ledstate;
Can be one line.
But most important question you are ignoring to answer / address is why do you use casting?
-- With Best Regards, Andy Shevchenko
| |