Messages in this thread | | | From | Vitaly Kuznetsov <> | Subject | Re: [PATCH 1/2] KVM: x86: Add vendor name to kvm_x86_ops, use it for error messages | Date | Fri, 22 Oct 2021 08:33:44 +0200 |
| |
Sean Christopherson <seanjc@google.com> writes:
> On Thu, Oct 21, 2021, Vitaly Kuznetsov wrote: >> > if (ops->disabled_by_bios()) { >> > - pr_err_ratelimited("kvm: disabled by bios\n"); >> > + pr_err_ratelimited("kvm: support for '%s' disabled by bios\n", >> > + ops->runtime_ops->name); >> >> >> I'd suggest we change this to >> >> pr_err_ratelimited("kvm: %s: virtualization disabled in BIOS\n", >> ops->runtime_ops->name); >> >> or something like that as generally, it makes little sense to search for >> 'KVM' in BIOS settings. You need too look for either 'Virtualization' or >> VT-x/AMD-v. > > I'd prefer to avoid VT-x/AMD-v so as not to speculate on the module being loaded > or the underlying hardware, e.g. I've no idea what Hygon, Zhaoxin, etc... use for > "code" names. > > What about > > pr_err_ratelimited("kvm: virtualization support for '%s' disabled by BIOS\n", > ops->runtime_ops->name); > > to add the virtualization flavor but still make it clear that error is coming > from the base kvm module.
Works for me, thanks! I just want to make sure people know what to do when they see the message.
-- Vitaly
| |