lkml.org 
[lkml]   [2021]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 4/6] PCI: brcmstb: Add control of subdevice voltage regulators
On Fri, Oct 22, 2021 at 10:06:57AM -0400, Jim Quinlan wrote:

> +static const char * const supplies[] = {
> + "vpcie3v3-supply",
> + "vpcie3v3aux-supply",
> + "brcm-ep-a-supply",
> + "brcm-ep-b-supply",
> +};

Why are you including "-supply" in the names here? That will lead to
a double -supply when we look in the DT which probably isn't what you're
looking for.

Also are you *sure* that the device has supplies with names like
"brcm-ep-a"? That seems rather unidiomatic for electrical engineering,
the names here are supposed to correspond to the names used in the
datasheet for the part.

> + /* This is for Broadcom STB/CM chips only */
> + if (pcie->type == BCM2711)
> + return 0;

It is a relief that other chips have managed to work out how to avoid
requiring power.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-10-22 16:32    [W:0.171 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site