lkml.org 
[lkml]   [2021]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCH v5 0/6] PCI: brcmstb: have host-bridge turn on sub-device power
    Date
    v5 [NOTE: It has been a while since v4.  Sorry]
    -- See "PCI: allow for callback to prepare nascent subdev"
    commit message for the cornerstone of this patchset
    and the reasons behind it. This is a new commit.
    -- The RC driver now looks into its DT children and
    turns on regulators for a sub-device, and this occurs
    prior to PCIe link as it must.
    -- Dropped commits not related to the focus of this patchset.

    v4 [NOTE: I'm not sure this fixes RobH and MarkB constraints but I'd
    like to use this pullreq as a basis for future discussion.]
    [Commit: Add bindings for ...]
    -- Fix syntax error in YAML bindings example (RobH)
    -- {vpcie12v,vpcie3v3}-supply props are back in root complex DT node
    (I believe RobH said this was okay)
    [Commit: Add control of ..]
    -- Do not do global search for regulator; now we look specifically
    for the property {vpcie12v,vpcie3v3}-supply in the root complex
    DT node and then call devm_regulator_bulk_get() (MarkB)
    -- Use devm_regulator_bulk_get() (Bjorn)
    -- s/EP/slot0 device/ (Bjorn)
    -- Spelling, capitalization (Bjorn)
    -- Have brcm_phy_stop() return a void (Bjorn)
    [Commit: Do not turn off ...]
    -- Capitalization (Bjorn)
    [Commit: Check return value ...]
    -- Commit message content (Bjorn)
    -- Move 6/6 hunk to 2/6 where it belongs (Bjorn)
    -- Move the rest of 6/6 before all other commits (Bjorn)

    v3 -- Driver now searches for EP DT subnode for any regulators to turn on.
    If present, these regulators have the property names
    "vpcie12v-supply" and "vpcie3v3-supply". The existence of these
    regulators in the EP subnode are currently pending as a pullreq
    in pci-bus.yaml at
    https://github.com/devicetree-org/dt-schema/pull/54
    (MarkB, RobH).
    -- Check return of brcm_set_regulators() (Florian)
    -- Specify one regulator string per line for easier update (Florian)
    -- Author/Committer/Signoff email changed from that of V2 from
    'james.quinlan@broadcom.com' to 'jim2101024@gmail.com'.

    v2 -- Use regulator bulk API rather than multiple calls (MarkB).

    v1 -- Bindings are added for fixed regulators that may power the EP device.
    -- The brcmstb RC driver is modified to control these regulators
    during probe, suspend, and resume.
    -- 7216 type SOCs have additional error reporting HW and a
    panic handler is added to dump its info.
    -- A missing return value check is added.

    Jim Quinlan (6):
    dt-bindings: PCI: Add bindings for Brcmstb EP voltage regulators
    PCI: allow for callback to prepare nascent subdev
    PCI: brcmstb: split brcm_pcie_setup() into two funcs
    PCI: brcmstb: Add control of subdevice voltage regulators
    PCI: brcmstb: Do not turn off regulators if EP can wake up
    PCI: brcmstb: change brcm_phy_stop() to return void

    .../bindings/pci/brcm,stb-pcie.yaml | 23 ++
    drivers/base/core.c | 5 +
    drivers/pci/controller/pcie-brcmstb.c | 231 ++++++++++++++++--
    drivers/pci/probe.c | 47 +++-
    include/linux/device.h | 3 +
    include/linux/pci.h | 3 +
    6 files changed, 286 insertions(+), 26 deletions(-)

    --
    2.17.1

    \
     
     \ /
      Last update: 2021-10-22 16:08    [W:4.213 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site