Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 22 Oct 2021 16:38:14 +0300 | Subject | Re: [PATCH v2 09/16] reset: starfive-jh7100: Add StarFive JH7100 reset driver |
| |
On Fri, Oct 22, 2021 at 4:35 PM Emil Renner Berthing <kernel@esmil.dk> wrote: > On Fri, 22 Oct 2021 at 14:56, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Thu, Oct 21, 2021 at 8:43 PM Emil Renner Berthing <kernel@esmil.dk> wrote:
...
> > Why all these ugly % 32 against constants? > > Because the JH7100_RST_ values goes higher than 31. There is a > BIT_MASK macro, but that does % BITS_PER_LONG and this is a 64bit > machine.
And? It's exactly what you have to use!
...
> > Can you convert this to simple > > > > if (assert) > > ret = readl_... > > else > > ret = readl_... > > > > below? > > I don't see how that would work. We're using the done value in in the > readl_poll_timeout. Maybe you can be a bit more explicit.
Supply done either == mask or == ^mask. Try it.
-- With Best Regards, Andy Shevchenko
| |