| Date | Fri, 22 Oct 2021 13:33:31 +0100 | From | "Russell King (Oracle)" <> | Subject | Re: [RFC net-next PATCH 07/16] net: phylink: Add helpers for c22 registers without MDIO |
| |
On Mon, Oct 04, 2021 at 03:15:18PM -0400, Sean Anderson wrote: > Some devices expose memory-mapped c22-compliant PHYs. Because these > devices do not have an MDIO bus, we cannot use the existing helpers. > Refactor the existing helpers to allow supplying the values for c22 > registers directly, instead of using MDIO to access them. Only get_state > and set_adversisement are converted, since they contain the most complex > logic.
I think this patch is useful on its own, there are certainly cases where being able to hold the MII bus lock while reading the BMSR/LPA registers would be advantageous. Please can you update the patch against net-next and submit it?
Thanks.
-- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
|