lkml.org 
[lkml]   [2021]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] platform/x86: lg-laptop: replace snprintf in show functions with sysfs_emit
From
Hi,

On 10/22/21 11:07, cgel.zte@gmail.com wrote:
> From: Ye Guojin <ye.guojin@zte.com.cn>
>
> coccicheck complains about the use of snprintf() in sysfs show
> functions:
> WARNING use scnprintf or sprintf
>
> Use sysfs_emit instead of scnprintf or sprintf makes more sense.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Ye Guojin <ye.guojin@zte.com.cn>

Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
> drivers/platform/x86/lg-laptop.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/platform/x86/lg-laptop.c b/drivers/platform/x86/lg-laptop.c
> index 7e9351c36389..ae9293024c77 100644
> --- a/drivers/platform/x86/lg-laptop.c
> +++ b/drivers/platform/x86/lg-laptop.c
> @@ -330,7 +330,7 @@ static ssize_t fan_mode_show(struct device *dev,
> status = r->integer.value & 0x01;
> kfree(r);
>
> - return snprintf(buffer, PAGE_SIZE, "%d\n", status);
> + return sysfs_emit(buffer, "%d\n", status);
> }
>
> static ssize_t usb_charge_store(struct device *dev,
> @@ -372,7 +372,7 @@ static ssize_t usb_charge_show(struct device *dev,
>
> kfree(r);
>
> - return snprintf(buffer, PAGE_SIZE, "%d\n", status);
> + return sysfs_emit(buffer, "%d\n", status);
> }
>
> static ssize_t reader_mode_store(struct device *dev,
> @@ -414,7 +414,7 @@ static ssize_t reader_mode_show(struct device *dev,
>
> kfree(r);
>
> - return snprintf(buffer, PAGE_SIZE, "%d\n", status);
> + return sysfs_emit(buffer, "%d\n", status);
> }
>
> static ssize_t fn_lock_store(struct device *dev,
> @@ -455,7 +455,7 @@ static ssize_t fn_lock_show(struct device *dev,
> status = !!r->buffer.pointer[0];
> kfree(r);
>
> - return snprintf(buffer, PAGE_SIZE, "%d\n", status);
> + return sysfs_emit(buffer, "%d\n", status);
> }
>
> static ssize_t battery_care_limit_store(struct device *dev,
> @@ -520,7 +520,7 @@ static ssize_t battery_care_limit_show(struct device *dev,
> if (status != 80 && status != 100)
> status = 0;
>
> - return snprintf(buffer, PAGE_SIZE, "%d\n", status);
> + return sysfs_emit(buffer, "%d\n", status);
> }
>
> static DEVICE_ATTR_RW(fan_mode);
>

\
 
 \ /
  Last update: 2021-10-22 11:16    [W:0.051 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site