| From | Andy Shevchenko <> | Date | Fri, 22 Oct 2021 11:50:52 +0300 | Subject | Re: [PATCH v2 01/16] RISC-V: Add StarFive SoC Kconfig option |
| |
On Thu, Oct 21, 2021 at 8:42 PM Emil Renner Berthing <kernel@esmil.dk> wrote: > > Add StarFive Kconfig option to select SoC specific and common drivers > required for these SoCs.
...
> +config SOC_STARFIVE > + bool "StarFive SoCs" > + select PINCTRL > + select RESET_CONTROLLER
> + select SIFIVE_PLIC
If this is well understood and platform related the above two are too generic. Why have you selected them?
> + help > + This enables support for StarFive SoC platform hardware.
Not too much to read here. What is the point of this help? I would elaborate what kind of platform it may support, what kind of drivers it selects due to necessity of the accomplishing the boot process, etc.
-- With Best Regards, Andy Shevchenko
|