Messages in this thread | | | Subject | Re: [PATCH v1] dt-bindings: opp: Allow multi-worded node names | From | Dmitry Osipenko <> | Date | Fri, 22 Oct 2021 10:39:22 +0300 |
| |
22.10.2021 09:50, Viresh Kumar пишет: > On 22-10-21, 09:40, Dmitry Osipenko wrote: >> 22.10.2021 07:43, Viresh Kumar пишет: >>> On 20-10-21, 09:46, Rob Herring wrote: >>>> On Wed, Oct 20, 2021 at 02:19:05AM +0300, Dmitry Osipenko wrote: >>>>> Not all OPP table names and OPP entries consist of a single word. In >>>>> particular NVIDIA Tegra OPP tables use multi-word names. Allow OPP node >>>>> and OPP entry name to have multi-worded names to silence DT checker >>>>> warnings about the multi-word names separated by hyphen. >>>>> >>>>> Reviewed-by: David Heidelberg <david@ixit.cz> >>>>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> >>>>> --- >>>>> Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 4 ++-- >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml >>>>> index ae3ae4d39843..298cf24af270 100644 >>>>> --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml >>>>> +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml >>>>> @@ -22,7 +22,7 @@ select: false >>>>> >>>>> properties: >>>>> $nodename: >>>>> - pattern: '^opp-table(-[a-z0-9]+)?$' >>>>> + pattern: '^opp-table(-[a-z0-9]+)*$' >>>> >>>> I don't see how this helps you. What I see needed upstream is a prefix: >>>> >>>> '-?opp-table(-[0-9]+)?$' >>> >>> I wonder if we should disallow that to keep naming more >> >> I also think that postfix variant should be disallowed for consistency. >> I sent out patches for both variants. >> >> V2 uses pattern that supports both naming schemes. If V2 is less >> appropriate, then please take this V1. > > I didn't like V2, we can mandate to keep it like opp-* and opp-table-*. > > This patch looked okay to me, lets see what Rob has to say. >
What we currently have for Tegra is a tegra-opps.dtsi and tegra.dtsi which includes the OPP's dtsi.
the tegra-opps.dtsi has this structure:
table: devname-opp-table { opp: ... };
and tegra.dtsi:
#include "tegra-opps.dtsi"
device@0000 { operating-points-v2 = <&table>; };
It just occurred to me that there is no need to move all tables to tegra.dtsi, but change structure of tegra-opps.dtsi to:
device@0000 { operating-points-v2 = <&table>;
table: opp-table { opp: ... }; };
Then there no need to change current naming scheme. Let me try to implement it and see how it goes.
| |