Messages in this thread | | | From | Rob Herring <> | Date | Thu, 21 Oct 2021 16:12:52 -0500 | Subject | Re: [PATCH] ARM: dts: spear13xx: Drop malformed 'interrupt-map' on PCI nodes |
| |
On Mon, Oct 4, 2021 at 1:14 AM Viresh Kumar <viresh.kumar@linaro.org> wrote: > > On 28-09-21, 14:21, Rob Herring wrote: > > The spear13xx PCI 'interrupt-map' property is not parse-able. > > '#interrupt-cells' is missing and there are 3 #address-cells. Based on the > > driver, the only supported interrupt is for MSI. Therefore, 'interrupt-map' > > is not needed. > > > > Cc: Viresh Kumar <vireshk@kernel.org> > > Cc: Shiraz Hashim <shiraz.linux.kernel@gmail.com> > > Cc: linux-arm-kernel@lists.infradead.org > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > arch/arm/boot/dts/spear1310.dtsi | 6 ------ > > arch/arm/boot/dts/spear1340.dtsi | 2 -- > > 2 files changed, 8 deletions(-) > > > > diff --git a/arch/arm/boot/dts/spear1310.dtsi b/arch/arm/boot/dts/spear1310.dtsi > > index c4b49baf9804..2f746a9428a7 100644 > > --- a/arch/arm/boot/dts/spear1310.dtsi > > +++ b/arch/arm/boot/dts/spear1310.dtsi > > @@ -82,8 +82,6 @@ pcie0: pcie@b1000000 { > > reg = <0xb1000000 0x4000>, <0x80000000 0x20000>; > > reg-names = "dbi", "config"; > > interrupts = <0 68 0x4>; > > - interrupt-map-mask = <0 0 0 0>; > > - interrupt-map = <0x0 0 &gic 0 68 0x4>; > > num-lanes = <1>; > > phys = <&miphy0 1>; > > phy-names = "pcie-phy"; > > @@ -101,8 +99,6 @@ pcie1: pcie@b1800000 { > > reg = <0xb1800000 0x4000>, <0x90000000 0x20000>; > > reg-names = "dbi", "config"; > > interrupts = <0 69 0x4>; > > - interrupt-map-mask = <0 0 0 0>; > > - interrupt-map = <0x0 0 &gic 0 69 0x4>; > > num-lanes = <1>; > > phys = <&miphy1 1>; > > phy-names = "pcie-phy"; > > @@ -120,8 +116,6 @@ pcie2: pcie@b4000000 { > > reg = <0xb4000000 0x4000>, <0xc0000000 0x20000>; > > reg-names = "dbi", "config"; > > interrupts = <0 70 0x4>; > > - interrupt-map-mask = <0 0 0 0>; > > - interrupt-map = <0x0 0 &gic 0 70 0x4>; > > num-lanes = <1>; > > phys = <&miphy2 1>; > > phy-names = "pcie-phy"; > > diff --git a/arch/arm/boot/dts/spear1340.dtsi b/arch/arm/boot/dts/spear1340.dtsi > > index 1a8f5e8b10e3..827e887afbda 100644 > > --- a/arch/arm/boot/dts/spear1340.dtsi > > +++ b/arch/arm/boot/dts/spear1340.dtsi > > @@ -47,8 +47,6 @@ pcie0: pcie@b1000000 { > > reg = <0xb1000000 0x4000>, <0x80000000 0x20000>; > > reg-names = "dbi", "config"; > > interrupts = <0 68 0x4>; > > - interrupt-map-mask = <0 0 0 0>; > > - interrupt-map = <0x0 0 &gic 0 68 0x4>; > > num-lanes = <1>; > > phys = <&miphy0 1>; > > phy-names = "pcie-phy"; > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Are you going to apply this?
Rob
| |