lkml.org 
[lkml]   [2021]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] [v2] selftests: bpf: Remove duplicated include in cgroup_helpers
On Mon, Oct 18, 2021 at 9:07 AM John Fastabend <john.fastabend@gmail.com> wrote:
>
> Wan Jiabing wrote:
> > Fix following checkincludes.pl warning:
> > ./scripts/checkincludes.pl tools/testing/selftests/bpf/cgroup_helpers.c
> > tools/testing/selftests/bpf/cgroup_helpers.c: unistd.h is included more
> > than once.
> >
> > Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> > ---
> > Changelog:
> > v2:
> > - Fix the commit description.
> > ---
>
> The Subject is a bit unusual. Typically it would be something like,
>
> "[PATCH bpf-next] selftests, remove duplicated include in cgroup_helpers"

Also for selftests we use "selftests/bpf: " prefix (at least we
generally try, for consistency). Fixed up, applied to bpf-next.
Thanks.

>
> For the actual patch though LGTM.
>
> Acked-by: John Fastabend <john.fastabend@gmail.com>

\
 
 \ /
  Last update: 2021-10-20 19:47    [W:0.046 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site