lkml.org 
[lkml]   [2021]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 1/2] mm/damon: Remove unnecessary variable initialization
Date
On Wed, 20 Oct 2021 09:42:32 +0800 Xin Hao <xhao@linux.alibaba.com> wrote:

> In 'damon_va_apply_three_regions', There is no
> need to set variable 'i' as 0
>
> Signed-off-by: Xin Hao <xhao@linux.alibaba.com>

I gave you my 'Reviewed-by:' for the last version of this patch, but seems you
missed putting it here. So, I'm giving it here again ;)

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

> ---
> mm/damon/vaddr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c
> index b8ba44f69db6..90be463efff7 100644
> --- a/mm/damon/vaddr.c
> +++ b/mm/damon/vaddr.c
> @@ -305,7 +305,7 @@ static void damon_va_apply_three_regions(struct damon_target *t,
> struct damon_addr_range bregions[3])
> {
> struct damon_region *r, *next;
> - unsigned int i = 0;
> + unsigned int i;
>
> /* Remove regions which are not in the three big regions now */
> damon_for_each_region_safe(r, next, t) {
> --
> 2.31.0

\
 
 \ /
  Last update: 2021-10-20 09:01    [W:0.068 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site