Messages in this thread | | | Date | Wed, 20 Oct 2021 13:34:09 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 0/2] perf jevents: Enable build warnings |
| |
On October 20, 2021 11:41:01 AM GMT-03:00, John Garry <john.garry@huawei.com> wrote: >On 20/10/2021 15:31, Arnaldo Carvalho de Melo wrote: >> Em Sat, Oct 16, 2021 at 12:48:25AM +0800, John Garry escreveu: >>> Currently jevents builds without any complier warning flags enabled. So >>> use newly-defined HOSTCFLAGS, which comes from EXTRA_WARNINGS. I am not >>> 100% confident that this is the best way, but sending out for review. >>> >>> Baseline is be8ecc57f180 (HEAD, acme/perf/core) perf srcline: Use >>> long-running addr2line per DSO >> >> Thanks, applied. >> > >Hi Arnaldo, > >I was going to send a v2, with changes according to James Clark's review > - that was to add -Wall & -Werror, but they caused a problem on your >perf/core branch as they triggered the warn fixed in commit b94729919db2. > >I suppose the best thing now is to send a patch on top once perf/core >contains that commit. Let me know otherwise.
Tests are running, if something fails, then I'll have to fix it and will not make my perf/core public, so I can replace what I have with a v2, otherwise you please send a patch on top after l make it public.
- Arnaldo > >Thanks
| |