Messages in this thread | | | From | Linus Torvalds <> | Date | Wed, 20 Oct 2021 06:02:23 -1000 | Subject | Re: [GIT PULL] NIOS2: fix for v5.15, part 2 |
| |
On Mon, Oct 18, 2021 at 9:59 AM Dinh Nguyen <dinguyen@kernel.org> wrote: > > - Renamed CTL_STATUS to CTL_FSTATUS to fix a redefined warning
Hmm. That's still some very generic names exposed in a arch header file that seems to get included (indirectly) almost everywhere.
I've pulled this, but I would suggest you name those flags not "CTL" but something that is more exclusive to nios2.
Btw, the same goes for some of the other macros in there that are currently unique - like "RDCTL". That's a name that I can see a driver using internally, and with nios2 being so unusual, it would take potentially a longish time before anybody even noticed.
Linus
| |