Messages in this thread | | | Date | Wed, 20 Oct 2021 11:59:07 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v2 1/5] tracing: Add support for creating hist trigger variables from literal |
| |
On Wed, 20 Oct 2021 08:55:23 -0700 Kalesh Singh <kaleshsingh@google.com> wrote:
> > BTW, why is there a limit to the number of constants? > > The motivation was to limit the number of hist_fields that can be > created for constants. These are also indirectly limited by the max > number of subexpressions (3) and the max number of vars/keys that can > be defined, so I don't feel strongly about keeping it.
Yeah. I see the limiting factor is the number of expressions and such. And as described in my other email, if you have two constants for a single operand, you can easily combine them into one.
-- Steve
| |