Messages in this thread | | | From | Kalesh Singh <> | Date | Wed, 20 Oct 2021 08:23:31 -0700 | Subject | Re: [PATCH v2 2/5] tracing: Add division and multiplication support for hist triggers |
| |
On Wed, Oct 20, 2021 at 8:13 AM Steven Rostedt <rostedt@goodmis.org> wrote: > > On Wed, 20 Oct 2021 07:54:59 -0700 > Kalesh Singh <kaleshsingh@google.com> wrote: > > > Is it worth adding something like this for the multiplication case as well? > > No, multiplication is a pretty fast operation, and the added branches to > test would cause more overhead than what you would save. But, division is a > very slow operation, and I believe that even with the extra branches it > would still help. > > If we do this, it should be a separate patch anyway, where we can actual do > measurements to see if there was an improvement, and revert if not.
Sounds good. Thanks for the clarification Steve.
- Kalesh
> > -- Steve
| |