Messages in this thread | | | Subject | Re: [PATCH] locking/test-ww_mutex: use swap() | From | Waiman Long <> | Date | Wed, 20 Oct 2021 09:59:29 -0400 |
| |
On 10/20/21 5:15 AM, cgel.zte@gmail.com wrote: > From: Changcheng Deng <deng.changcheng@zte.com.cn> > > Use swap() in order to make code cleaner. Issue found by coccinelle. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn> > --- > kernel/locking/test-ww_mutex.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/kernel/locking/test-ww_mutex.c b/kernel/locking/test-ww_mutex.c > index 353004155d65..fa021b8a9edc 100644 > --- a/kernel/locking/test-ww_mutex.c > +++ b/kernel/locking/test-ww_mutex.c > @@ -389,7 +389,7 @@ struct stress { > static int *get_random_order(int count) > { > int *order; > - int n, r, tmp; > + int n, r; > > order = kmalloc_array(count, sizeof(*order), GFP_KERNEL); > if (!order) > @@ -400,11 +400,8 @@ static int *get_random_order(int count) > > for (n = count - 1; n > 1; n--) { > r = get_random_int() % (n + 1); > - if (r != n) { > - tmp = order[n]; > - order[n] = order[r]; > - order[r] = tmp; > - } > + if (r != n) > + swap(order[n], order[r]); > } > > return order;
Acked-by: Waiman Long <longman@redhat.com>
| |