Messages in this thread | | | Subject | Re: [PATCH] staging: vt6655: Rename `dwAL2230InitTable` array | From | Joe Perches <> | Date | Wed, 20 Oct 2021 06:44:19 -0700 |
| |
On Wed, 2021-10-20 at 14:28 +0100, Karolina Drobnik wrote: > Drop Hungarian notation prefix in `dwAL2230InitTable` array. > Change it to use snake case. > > Fix issue detected by checkpatch.pl: > CHECK: Avoid CamelCase: <dwAL2230InitTable>
Seems fine.
trivial suggestion:
> diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c [] > @@ -33,7 +33,7 @@ > #define SWITCH_CHANNEL_DELAY_AL7230 200 /* us */ > #define AL7230_PWR_IDX_LEN 64 > > -static const unsigned long dwAL2230InitTable[CB_AL2230_INIT_SEQ] = { > +static const unsigned long al2230_init_table[CB_AL2230_INIT_SEQ] = { > 0x03F79000 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW, > 0x03333100 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW, > 0x01A00200 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
In this file there are more than 100 uses of
(BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW
Maybe add a define for it and substitute the uses for the define.
| |