Messages in this thread | | | Date | Wed, 20 Oct 2021 08:41:30 -0500 | From | Rob Herring <> | Subject | Re: [PATCH v2 02/24] PCI: Set error response in config access defines when ops->read() fails |
| |
On Fri, Oct 15, 2021 at 07:58:17PM +0530, Naveen Naidu wrote: > Make PCI_OP_READ and PCI_USER_READ_CONFIG set the data value with error > response (~0), when the PCI device read by a host controller fails. > > This ensures that the controller drivers no longer need to fabricate > (~0) value when they detect error. It also gurantees that the error > response (~0) is always set when the controller drivers fails to read a > config register from a device. > > This makes error response fabrication consistent and helps in removal of > a lot of repeated code. > > Suggested-by: Rob Herring <robh@kernel.org> > Signed-off-by: Naveen Naidu <naveennaidu479@gmail.com> > --- > drivers/pci/access.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-)
Reviewed-by: Rob Herring <robh@kernel.org>
| |