lkml.org 
[lkml]   [2021]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] i2c: virtio: fix completion handling
    On 20-10-21, 12:38, Vincent Whitchurch wrote:
    > I don't quite understand how that would be safe since
    > virtqueue_add_sgs() can fail after a few iterations and all queued
    > request buffers can have FAIL_NEXT set. In such a case, we would end up
    > waiting forever with your proposed change, wouldn't we?

    Good point. I didn't think of that earlier.

    I think a good simple way of handling this is counting the number of
    buffers sent and received. Once they match, we are done. That
    shouldn't break anything else I believe.

    --
    viresh

    \
     
     \ /
      Last update: 2021-10-20 12:47    [W:3.114 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site