Messages in this thread Patch in this message | | | Date | Wed, 20 Oct 2021 11:18:53 +0200 | From | Simon Horman <> | Subject | Re: [PATCH linux-next] octeontx2-af: Remove redundant assignment operations |
| |
On Mon, Oct 18, 2021 at 09:16:12AM +0000, luo penghao wrote: > From: penghao luo <luo.penghao@zte.com.cn>
I think the correct patch-prefix for this would be:
[PATCH net-next] sky2:
> > the variable err will be reassigned on subsequent branches, and this > assignment does not perform related value operations. > > clang_analyzer complains as follows: > > drivers/net/ethernet/marvell/sky2.c:4988: warning: > > Although the value stored to 'err' is used in the enclosing expression, > the value is never actually read from 'err'. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: penghao luo <luo.penghao@zte.com.cn> > --- > drivers/net/ethernet/marvell/sky2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c > index 3cb9c12..6428ae5 100644 > --- a/drivers/net/ethernet/marvell/sky2.c > +++ b/drivers/net/ethernet/marvell/sky2.c > @@ -4907,7 +4907,7 @@ static int sky2_probe(struct pci_dev *pdev, const struct pci_device_id *ent) > pci_set_master(pdev); > > if (sizeof(dma_addr_t) > sizeof(u32) && > - !(err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(64)))) { > + !(dma_set_mask(&pdev->dev, DMA_BIT_MASK(64)))) {
I think you can drop the parentheses around the call to dma_set_mask()
> using_dac = 1; > err = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64)); > if (err < 0) { > -- > 2.15.2 > >
| |