Messages in this thread Patch in this message | | | From | cgel.zte@gmail ... | Subject | [PATCH] locking/rwbase: fix boolreturn.cocci warning | Date | Wed, 20 Oct 2021 08:44:07 +0000 |
| |
From: Changcheng Deng <deng.changcheng@zte.com.cn>
./kernel/locking/rwbase_rt.c: 226: 9-10: WARNING: return of 0/1 in function '__rwbase_write_trylock' with return type bool
Return statements in functions returning bool should use true/false instead of 1/0.
Reported-by: Zeal Robot <zealci@zte.com.cn> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn> --- kernel/locking/rwbase_rt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/locking/rwbase_rt.c b/kernel/locking/rwbase_rt.c index 6fd3162e4098..e3dd458ee0c9 100644 --- a/kernel/locking/rwbase_rt.c +++ b/kernel/locking/rwbase_rt.c @@ -223,10 +223,10 @@ static inline bool __rwbase_write_trylock(struct rwbase_rt *rwb) */ if (!atomic_read_acquire(&rwb->readers)) { atomic_set(&rwb->readers, WRITER_BIAS); - return 1; + return true; } - return 0; + return false; } static int __sched rwbase_write_lock(struct rwbase_rt *rwb, -- 2.25.1
| |