lkml.org 
[lkml]   [2021]   [Oct]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/3] mtd: core: protect access to mtd devices while in suspend
On Wed, Oct 20, 2021 at 09:12:28AM +0200, Miquel Raynal wrote:
> >
> > Actually, this version is even cleaner:
> >
> > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
> > index 3d6c6e880520..98c39b7f6279 100644
> > --- a/drivers/mtd/nand/raw/nand_base.c
> > +++ b/drivers/mtd/nand/raw/nand_base.c
> > @@ -6222,8 +6222,6 @@ static int nand_scan_tail(struct nand_chip *chip)
> > mtd->_sync = nand_sync;
> > mtd->_lock = nand_lock;
> > mtd->_unlock = nand_unlock;
> > - mtd->_suspend = nand_suspend;
> > - mtd->_resume = nand_resume;
> > mtd->_reboot = nand_shutdown;
> > mtd->_block_isreserved = nand_block_isreserved;
> > mtd->_block_isbad = nand_block_isbad;
> > @@ -6261,14 +6259,20 @@ static int nand_scan_tail(struct nand_chip *chip)
> > goto err_free_interface_config;
> >
> > /* Check, if we should skip the bad block table scan */
> > - if (chip->options & NAND_SKIP_BBTSCAN)
> > - return 0;
> > -
> > - /* Build bad block table */
> > - ret = nand_create_bbt(chip);
> > - if (ret)
> > - goto err_free_secure_regions;
> > + if (chip->options & NAND_SKIP_BBTSCAN) {
> > + /* Build bad block table */
> > + ret = nand_create_bbt(chip);
> > + if (ret)
> > + goto err_free_secure_regions;
> > + }
>
> Nice idea.
>
> >
> > + /*
> > + * Populate the suspend/resume hooks after the BBT has been scanned to
> > + * avoid using the suspend lock and resume waitqueue which are only
> > + * initialized when mtd_device_register() is called.
> > + */
> > + mtd->_suspend = nand_suspend;
> > + mtd->_resume = nand_resume;
> > return 0;
> >
> > err_free_secure_regions:

Could be a nice idea, but it doesn't work...
gpmi-nand.c calls nand_create_bbt() after this have run ;)

/Sean

\
 
 \ /
  Last update: 2021-10-20 09:24    [W:0.085 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site