Messages in this thread | | | From | Martin Blumenstingl <> | Date | Sat, 2 Oct 2021 19:06:15 +0200 | Subject | Re: [PATCH v3 6/9] iio: adc: meson_saradc: Make use of the helper function dev_err_probe() |
| |
Hi Jonathan,
On Sat, Oct 2, 2021 at 6:05 PM Jonathan Cameron <jic23@kernel.org> wrote: > > On Sat, 2 Oct 2021 15:01:56 +0200 > Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > > > On Tue, Sep 28, 2021 at 4:20 PM Cai Huoqing <caihuoqing@baidu.com> wrote: > > > > > > When possible use dev_err_probe help to properly deal with the > > > PROBE_DEFER error, the benefit is that DEFER issue will be logged > > > in the devices_deferred debugfs file. > > > Using dev_err_probe() can reduce code size, and the error value > > > gets printed. > > > > > > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com> > > Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > as well as: > > Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > # Odroid-C1 > Hi Martin, > > Confusing tag. Was the second meant to be a Tested-by? my bad - it is indeed supposed to be: Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Testing was done on a Meson8b Odroid-C1 board.
Best regards, Martin
| |