Messages in this thread | | | Date | Tue, 19 Oct 2021 18:18:53 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v2] net: marvell: prestera: add firmware v4.0 support |
| |
> - Major changes have been made to new v4.0 FW ABI to add support of new features, > introduce the stability of the FW ABI and ensure better forward compatibility > for the future vesrions.
So this point needs bring out in the commit message. You need to explain why you think you will never need another ABI break. How your new design allows extensible, what you have fixed in your old design which has causes two ABI breaks.
Given this is the second time you have broken the ABI, i need convincing.
> - All current platforms using this driver have dedicated OOB mgmt port, thus the > user still be able to do upgrade of the FW. So, no "Bricks in broom closets" :).
So your cabling guidelines suggest a dedicated Ethernet cable from the broom closet to the NOC for the OOB port? I suspect most users ignore this, and do management over the network. They only use the OOB port when they have bricked the device because they installed a kernel upgrade over the network, without upgrading the firmware.
Andrew
| |