lkml.org 
[lkml]   [2021]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v3 5/7] surface: surface3_power: Drop redundant acpi_bus_get_device() call
    From
    Hi,

    On 10/13/21 18:12, Rafael J. Wysocki wrote:
    > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    >
    > If the ACPI companion of a given device is not present, the result
    > of the ACPI_HANDLE() evaluation for it will be NULL, so calling
    > acpi_bus_get_device() on ACPI_HANDLE() result in order to validate
    > it is redundant.
    >
    > Drop the redundant acpi_bus_get_device() call from mshw0011_notify()
    > along with a local variable related to it.
    >
    > No intentional functional impact.
    >
    > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    > Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>

    Thank you for your patch, I've applied this patch to my review-hans
    branch:
    https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

    Note it will show up in my review-hans branch once I've pushed my
    local branch there, which might take a while.

    Once I've run some tests on this branch the patches there will be
    added to the platform-drivers-x86/for-next branch and eventually
    will be included in the pdx86 pull-request to Linus for the next
    merge-window.

    Regards,

    Hans


    > ---
    >
    > v2 -> v3:
    > * Resend with a different From and S-o-b address and with R-by from
    > Maximilian. No other changes.
    >
    > ---
    > drivers/platform/surface/surface3_power.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > Index: linux-pm/drivers/platform/surface/surface3_power.c
    > ===================================================================
    > --- linux-pm.orig/drivers/platform/surface/surface3_power.c
    > +++ linux-pm/drivers/platform/surface/surface3_power.c
    > @@ -159,12 +159,11 @@ mshw0011_notify(struct mshw0011_data *cd
    > unsigned int *ret_value)
    > {
    > union acpi_object *obj;
    > - struct acpi_device *adev;
    > acpi_handle handle;
    > unsigned int i;
    >
    > handle = ACPI_HANDLE(&cdata->adp1->dev);
    > - if (!handle || acpi_bus_get_device(handle, &adev))
    > + if (!handle)
    > return -ENODEV;
    >
    > obj = acpi_evaluate_dsm_typed(handle, &mshw0011_guid, arg1, arg2, NULL,
    >
    >
    >

    \
     
     \ /
      Last update: 2021-10-19 16:57    [W:2.325 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site