lkml.org 
[lkml]   [2021]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] scsi: core: return -ENOMEM on ips_init_phase1() allocation failure
From
Date
On Tue, 2021-10-19 at 18:50 +0800, Jiapeng Chong wrote:
> From: chongjiapeng <jiapeng.chong@linux.alibaba.com>
>
> Fixes the following smatch warning:
>
> drivers/scsi/ips.c:6901 ips_init_phase1() warn: returning -1 instead
> of -ENOMEM is sloppy.

Really, like megaraid, it's not. ips_init_phase1() returns either
Success or -1. If it returns -1, that gets translated to -ENODEV so,
again, we'd lose this nuanced return completely.

James


\
 
 \ /
  Last update: 2021-10-19 13:51    [W:0.035 / U:5.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site