Messages in this thread | | | Date | Tue, 19 Oct 2021 12:52:02 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 12/16] pinctrl: starfive: Add pinctrl driver for StarFive SoCs |
| |
On Mon, Oct 18, 2021 at 07:02:43PM +0200, Emil Renner Berthing wrote: > On Mon, 18 Oct 2021 at 18:29, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Mon, Oct 18, 2021 at 7:23 PM Andy Shevchenko > > <andy.shevchenko@gmail.com> wrote:
...
> > Having a second look I found even problematic error paths because of > > mixing devm_*() with non-devm_*() calls, which only assures me that > > your ->probe() error path is broken and should be revisited. > > So do you want to expand on that now or should I send v2 first?
Here is not enough context anymore to point out. I expect one to have done their homework anyway.
-- With Best Regards, Andy Shevchenko
| |