Messages in this thread | | | Date | Tue, 19 Oct 2021 10:23:08 +0100 | From | Sudeep Holla <> | Subject | Re: [PATCH -next] drivers/base/arch_topology.c: remove superfluous header |
| |
On Wed, Sep 29, 2021 at 03:31:38AM +0800, Mianhan Liu wrote: > arch_topology.c hasn't use any macro or function declared in linux/percpu.h, > linux/smp.h and linux/string.h. > Thus, these files can be removed from arch_topology.c safely without > affecting the compilation of the drivers/base/ module > > Signed-off-by: Mianhan Liu <liumh1@shanghaitech.edu.cn> > > --- > drivers/base/arch_topology.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c > index 434076659..92200873b 100644 > --- a/drivers/base/arch_topology.c > +++ b/drivers/base/arch_topology.c > @@ -12,15 +12,12 @@ > #include <linux/device.h> > #include <linux/of.h> > #include <linux/slab.h> > -#include <linux/string.h> > #include <linux/sched/topology.h> > #include <linux/cpuset.h> > #include <linux/cpumask.h> > #include <linux/init.h> > -#include <linux/percpu.h>
Don't you need linux/percpu-defs.h for DEFINE_PER_CPU then ?
-- Regards, Sudeep
| |