Messages in this thread | | | From | Himanshu Madhani <> | Subject | Re: [PATCH] scsi: mpt3sas: make mpt3sas_dev_attrs static | Date | Wed, 20 Oct 2021 01:58:52 +0000 |
| |
> On Oct 19, 2021, at 5:27 AM, Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote: > > From: chongjiapeng <jiapeng.chong@linux.alibaba.com> > > This symbol is not used outside of mpt3sas_ctl.c, so marks it static. > > Fixes the following sparse warning: > > drivers/scsi/mpt3sas/mpt3sas_ctl.c:3988:18: warning: symbol > 'mpt3sas_dev_attrs' was not declared. Should it be static? > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Fixes: 1bb3ca27d2ca ("scsi: mpt3sas: Switch to attribute groups") > Signed-off-by: chongjiapeng <jiapeng.chong@linux.alibaba.com> > --- > drivers/scsi/mpt3sas/mpt3sas_ctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/mpt3sas/mpt3sas_ctl.c b/drivers/scsi/mpt3sas/mpt3sas_ctl.c > index 0aabc9761be1..05b6c6a073c3 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_ctl.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_ctl.c > @@ -3985,7 +3985,7 @@ sas_ncq_prio_enable_store(struct device *dev, > } > static DEVICE_ATTR_RW(sas_ncq_prio_enable); > > -struct attribute *mpt3sas_dev_attrs[] = { > +static struct attribute *mpt3sas_dev_attrs[] = { > &dev_attr_sas_address.attr, > &dev_attr_sas_device_handle.attr, > &dev_attr_sas_ncq_prio_supported.attr, > -- > 2.19.1.6.gb485710b >
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
-- Himanshu Madhani Oracle Linux Engineering
| |