lkml.org 
[lkml]   [2021]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 101/151] net: arc: select CRC32
    Date
    From: Vegard Nossum <vegard.nossum@oracle.com>

    commit e599ee234ad4fdfe241d937bbabd96e0d8f9d868 upstream.

    Fix the following build/link error by adding a dependency on the CRC32
    routines:

    ld: drivers/net/ethernet/arc/emac_main.o: in function `arc_emac_set_rx_mode':
    emac_main.c:(.text+0xb11): undefined reference to `crc32_le'

    The crc32_le() call comes through the ether_crc_le() call in
    arc_emac_set_rx_mode().

    [v2: moved the select to ARC_EMAC_CORE; the Makefile is a bit confusing,
    but the error comes from emac_main.o, which is part of the arc_emac module,
    which in turn is enabled by CONFIG_ARC_EMAC_CORE. Note that arc_emac is
    different from emac_arc...]

    Fixes: 775dd682e2b0ec ("arc_emac: implement promiscuous mode and multicast filtering")
    Cc: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
    Link: https://lore.kernel.org/r/20211012093446.1575-1-vegard.nossum@oracle.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/arc/Kconfig | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/ethernet/arc/Kconfig
    +++ b/drivers/net/ethernet/arc/Kconfig
    @@ -21,6 +21,7 @@ config ARC_EMAC_CORE
    depends on ARC || ARCH_ROCKCHIP || COMPILE_TEST
    select MII
    select PHYLIB
    + select CRC32

    config ARC_EMAC
    tristate "ARC EMAC support"

    \
     
     \ /
      Last update: 2021-10-18 15:58    [W:4.246 / U:0.728 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site