lkml.org 
[lkml]   [2021]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 003/151] ALSA: usb-audio: Fix a missing error check in scarlett gen2 mixer
    Date
    From: Takashi Iwai <tiwai@suse.de>

    commit 8ec59ac3ad29891c0afef627640df36f2daa0349 upstream.

    The check of the returned error code is missing in
    scarlett2_update_monitor_other(). Let's fix it.

    Fixes: d5bda7e03982 ("ALSA: usb-audio: scarlett2: Add support for the talkback feature")
    Reported-by: kernel test robot <lkp@intel.com>
    Cc: <stable@vger.kernel.org>
    Link: https://lore.kernel.org/r/202109131831.9IodEzRx-lkp@intel.com
    Link: https://lore.kernel.org/r/20210929073540.9611-1-tiwai@suse.de
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    sound/usb/mixer_scarlett_gen2.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/sound/usb/mixer_scarlett_gen2.c
    +++ b/sound/usb/mixer_scarlett_gen2.c
    @@ -2450,6 +2450,8 @@ static int scarlett2_update_monitor_othe
    err = scarlett2_usb_get_config(mixer,
    SCARLETT2_CONFIG_TALKBACK_MAP,
    1, &bitmap);
    + if (err < 0)
    + return err;
    for (i = 0; i < num_mixes; i++, bitmap >>= 1)
    private->talkback_map[i] = bitmap & 1;
    }

    \
     
     \ /
      Last update: 2021-10-18 15:50    [W:4.112 / U:0.908 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site