lkml.org 
[lkml]   [2021]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 64/69] drm/msm/dsi: fix off by one in dsi_bus_clk_enable error handling
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit c8f01ffc83923a91e8087aaa077de13354a7aa59 upstream.

    This disables a lock which wasn't enabled and it does not disable
    the first lock in the array.

    Fixes: 6e0eb52eba9e ("drm/msm/dsi: Parse bus clocks from a list")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    Link: https://lore.kernel.org/r/20211001123409.GG2283@kili
    Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    Signed-off-by: Rob Clark <robdclark@chromium.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
    +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
    @@ -460,7 +460,7 @@ static int dsi_bus_clk_enable(struct msm

    return 0;
    err:
    - for (; i > 0; i--)
    + while (--i >= 0)
    clk_disable_unprepare(msm_host->bus_clks[i]);

    return ret;

    \
     
     \ /
      Last update: 2021-10-18 15:40    [W:4.194 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site