lkml.org 
[lkml]   [2021]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 2/2] reset: mchp: sparx5: Extend support for lan966x
From
Date
On Thu, 2021-10-14 at 17:40 +0200, Horatiu Vultur wrote:
>
> > > + */
> > > + err = mchp_sparx5_map_syscon(pdev, "cuphy-syscon", &ctx->cuphy_ctrl);
> > > + if (err && err != -ENODEV)
> > > + return err;
> >
> > So -ENODEV should return an error if .cuphy_reg is set?
>
> I am not sure I follow this.
> If cuphy-syscon is not set then mchp_sparx5_map_syscon will return
> -ENODEV. This can be ignored for sparx5 as this is not required.
> If cuphy-syscon is set then if mchp_sparx5_map_syscon returns an error
> then report this error.

My point was that in case of cuphy-syscon missing from the DT, the
lan966x compatible reset controller should probably throw the error
instead of ignoring it. With v4 this is not relevant any more.

regards
Philipp

\
 
 \ /
  Last update: 2021-10-18 12:44    [W:0.042 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site