Messages in this thread | | | From | Andy Shevchenko <> | Date | Mon, 18 Oct 2021 13:16:27 +0300 | Subject | Re: linux-next: build failure after merge of the akpm-current tree |
| |
On Mon, Oct 18, 2021 at 12:07 PM Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote: > On 18/10/2021 10.45, Stephen Rothwell wrote: > > On Mon, 18 Oct 2021 11:01:18 +0300 Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > >> On Mon, Oct 18, 2021 at 6:49 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
...
> >> I thought that it makes sense to have STACK_MAGIC also in this header. Thoughts? > > > > You might want to think of a different name for the header file then. > > Eh, it seems more reasonable to leave it in kernel.h, then figure out > how to get rid of it completely. AFAICT it's only used in one single > place under arch/ (and I can't figure out how that magic value is > supposed to get there in the first place... that arch was thrown out in > 2013 and resurrected in 2015, but that particular line doesn't make > sense), and then in some i915 code which might as well define their own > cookie.
It's used in two places and probably we may just move it to these two users, I don't believe will we ever have i915 together with h8300.
-- With Best Regards, Andy Shevchenko
| |