lkml.org 
[lkml]   [2021]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 net-next 5/7] net: dsa: tag_rtl8_4: add realtek 8 byte protocol 4 tag
Date
On 10/16/21 8:04 AM, DENG Qingfang wrote:
> On Fri, Oct 15, 2021 at 07:10:26PM +0200, Alvin Šipraga wrote:
>> +static struct sk_buff *rtl8_4_tag_xmit(struct sk_buff *skb,
>> + struct net_device *dev)
>> +{
>> + struct dsa_port *dp = dsa_slave_to_port(dev);
>> + __be16 *tag;
>> +
>> + /* Pad out so the (stripped) packet is at least 64 bytes long
>> + * (including FCS), otherwise the switch will drop the packet.
>> + * Then we need an additional 8 bytes for the Realtek tag.
>> + */
>> + if (unlikely(__skb_put_padto(skb, ETH_ZLEN + RTL8_4_TAG_LEN, false)))
>> + return NULL;
>
> Is this still required if you set rtl8365mb_cpu_rxlen to 64 bytes already?

Apparently not - nice catch. I've removed it for what will be v4. :)

>
>> +
>> + skb_push(skb, RTL8_4_TAG_LEN);
>> +

\
 
 \ /
  Last update: 2021-10-18 09:59    [W:0.171 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site