Messages in this thread | | | From | Julian Braha <> | Subject | Re: [PATCH v2] drm/panel/tianma-tl057fvxp01: add panel for Motorola Moto G6 | Date | Mon, 18 Oct 2021 18:49:50 -0400 |
| |
On Sunday, October 17, 2021 1:33:05 PM EDT Sam Ravnborg wrote: > Hi Julian, > > On Sun, Aug 08, 2021 at 04:08:54PM -0400, Julian Braha wrote: > > This is a 5.7" 2160x1080 panel found on the Motorola Moto G6. > > There may be other smartphones using it, as well. > > > > Signed-off-by: Julian Braha <julianbraha@gmail.com> > > Sorry for coming back so late. Driver looks good and is almost > ready to apply. One detail you need to fix, see below. > > Sam > > > --- > > + > > +static const struct of_device_id tianma_tl057fvxp01_of_match[] = { > > + { .compatible = "tianma,tl057fvxp01" }, > > + { /* sentinel */ } > > +}; > The compatible needs to be documented before I can include the driver in > the kernel. Please add a patch that document the compatible - maybe as a > new binding file but preferably as part of one of the existing binding > files. > > Sam >
Hi Sam,
Thanks for your feedback! I've submitted a second patch for the bindings.
- Julian Braha
| |