Messages in this thread | | | From | Doug Anderson <> | Date | Mon, 18 Oct 2021 14:45:09 -0700 | Subject | Re: [PATCH] arm64: dts: qcom: pmk8350: Make RTC disabled by default; enable on sc7280-idp |
| |
Bjorn,
On Wed, Sep 29, 2021 at 9:00 PM <skakit@codeaurora.org> wrote: > > On 2021-09-30 04:08, Douglas Anderson wrote: > > The RTC on the pmk8350 is not useful on all boards. Some boards may > > not provide backup power to the PMIC but might have another RTC on the > > board that does have backup power. In this case it's better to not use > > the RTC on the PMIC. > > > > At the moment, the only boards that includes this PMIC are sc7280-idp > > and sc7280-idp2. On sc7280-idp I'm not aware of any other RTCs, but > > sc7280-idp2 has a Chrome OS EC on it and this is intended to provide > > the RTC for the AP. > > > > Let's do what we normally do for hardware that's not used by all > > boards and set it to a default status of "disabled" and then enable it > > on the boards that need it. > > > > NOTE: for sc7280-idp it's _possible_ we might also want to add > > `allow-set-time;`. That could be the subject of a future patch if it > > is indeed true. > > > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > > > Reviewed-by: Satya Priya <skakit@codeaurora.org>
If you're still accepting patches for 5.16, it'd be keen if you'd consider taking this one. Thanks!
-Doug
| |