lkml.org 
[lkml]   [2021]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Kconfig issue with LOG_CPU_MAX_BUF_SHIFT + BASE_SMALL
On Mon, Oct 18, 2021 at 11:21:22AM +0200, Vegard Nossum wrote:
> The most straightforward fix seems to be change init/Kconfig and
> LOG_CPU_MAX_BUF_SHIFT to say:
>
> default 12 if BASE_SMALL=0
> default 0 if BASE_SMALL!=0

Thanks for reporting! Please feel free to send a patch with a Fixes
annotation.

> In fact, I'm not sure what the point of BASE_SMALL is in the first
> place. Should we get rid of it altogether? (git blame says it's been
> there since the initial commit.)

That's just the inverse of BASE_FULL, if you'd like to remove BASE_SMALL
take it up with the folks with added BASE_FULL, but I have a feeling
that may not be something they are up for.

Luis

\
 
 \ /
  Last update: 2021-10-18 22:53    [W:0.033 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site