lkml.org 
[lkml]   [2021]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 6/6] drm/meson: encoder_cvbs: switch to bridge with ATTACH_NO_CONNECTOR
    From
    Date
    Hi,

    On 16/10/2021 00:34, Martin Blumenstingl wrote:
    > Hi Neil, Hi Sam,
    >
    > On Fri, Oct 15, 2021 at 4:11 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
    > [...]
    >> +static const struct drm_bridge_funcs meson_encoder_cvbs_bridge_funcs = {
    >> + .attach = meson_encoder_cvbs_attach,
    >> + .enable = meson_encoder_cvbs_enable,
    >> + .disable = meson_encoder_cvbs_disable,
    >> + .mode_valid = meson_encoder_cvbs_mode_valid,
    >> + .get_modes = meson_encoder_cvbs_get_modes,
    >> + .atomic_enable = meson_encoder_cvbs_atomic_enable,
    > I did some testing on boards where u-boot doesn't initialize the video outputs.
    > It seems that meson_encoder_cvbs_enable() is never called with this patch.
    > meson_encoder_cvbs_atomic_enable() is called though.
    >
    > From what I can see in drm_bridge.c [0] this is even expected.
    > Does this mean that we need to move all logic from .enable to
    > .atomic_enable (and same with .disable -> moving that logic to
    > .atomic_disable)?
    >
    > The same comment applies to the HDMI patch.

    Good point, I'll fix that for both patches !

    Neil

    >
    >
    > Best regards,
    > Martin
    >
    >
    > [0] https://elixir.bootlin.com/linux/v5.15-rc5/source/drivers/gpu/drm/drm_bridge.c#L717
    >

    \
     
     \ /
      Last update: 2021-10-18 09:41    [W:4.284 / U:0.688 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site