Messages in this thread Patch in this message | | | From | Tim Gardner <> | Subject | [PATCH][linux-next] net/smc: prevent NULL dereference in smc_find_rdma_v2_device_serv() | Date | Mon, 18 Oct 2021 12:31:28 -0600 |
| |
Coverity complains of a possible NULL dereference in smc_find_rdma_v2_device_serv().
1782 smc_v2_ext = smc_get_clc_v2_ext(pclc); CID 121151 (#1 of 1): Dereference null return value (NULL_RETURNS) 5. dereference: Dereferencing a pointer that might be NULL smc_v2_ext when calling smc_clc_match_eid. [show details] 1783 if (!smc_clc_match_eid(ini->negotiated_eid, smc_v2_ext, NULL, NULL)) 1784 goto not_found;
Fix this by checking for NULL.
Fixes: e49300a6bf621 ("net/smc: add listen processing for SMC-Rv2") Cc: Karsten Graul <kgraul@linux.ibm.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Jakub Kicinski <kuba@kernel.org> Cc: linux-s390@vger.kernel.org Cc: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Tim Gardner <tim.gardner@canonical.com> --- net/smc/af_smc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c index 5e50e007a7da..ff23d5b40793 100644 --- a/net/smc/af_smc.c +++ b/net/smc/af_smc.c @@ -1780,7 +1780,7 @@ static void smc_find_rdma_v2_device_serv(struct smc_sock *new_smc, goto not_found; smc_v2_ext = smc_get_clc_v2_ext(pclc); - if (!smc_clc_match_eid(ini->negotiated_eid, smc_v2_ext, NULL, NULL)) + if (!smc_v2_ext || !smc_clc_match_eid(ini->negotiated_eid, smc_v2_ext, NULL, NULL)) goto not_found; /* prepare RDMA check */ -- 2.33.1
| |