lkml.org 
[lkml]   [2021]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v3 1/2] dt-bindings: arm: Add OP-TEE transport for SCMI
    Date
    On Mon, 18 Oct 2021 13:40:45 +0200, Etienne Carriere wrote:
    > Introduce compatible "linaro,scmi-optee" for SCMI transport channel
    > based on an OP-TEE service invocation. The compatible mandates a
    > channel ID defined with property "linaro,optee-channel-id".
    >
    > Cc: devicetree@vger.kernel.org
    > Cc: Rob Herring <robh+dt@kernel.org>
    > Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
    > ---
    > Changes since v2:
    > - Define mandatory property linaro,optee-channel-id
    > - Rebased on yaml description file
    >
    > Changes since v1:
    > - Removed modification regarding mboxes property description.
    > ---
    > .../bindings/firmware/arm,scmi.yaml | 44 +++++++++++++++++++
    > 1 file changed, 44 insertions(+)
    >

    My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
    on your patch (DT_CHECKER_FLAGS is new in v5.13):

    yamllint warnings/errors:

    dtschema/dtc warnings/errors:
    /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/arm,scmi.yaml: patternProperties:^protocol@[0-9a-f]+$:properties:linaro,optee-channel-id: 'description' is a required property
    hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
    from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
    /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/arm,scmi.yaml: patternProperties:^protocol@[0-9a-f]+$:properties:linaro,optee-channel-id: 'oneOf' conditional failed, one must be fixed:
    'type' is a required property
    hint: A vendor boolean property can use "type: boolean"
    Additional properties are not allowed ('maxItems' was unexpected)
    hint: A vendor boolean property can use "type: boolean"
    /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/arm,scmi.yaml: patternProperties:^protocol@[0-9a-f]+$:properties:linaro,optee-channel-id: 'oneOf' conditional failed, one must be fixed:
    'enum' is a required property
    'const' is a required property
    hint: A vendor string property with exact values has an implicit type
    from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
    /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/arm,scmi.yaml: patternProperties:^protocol@[0-9a-f]+$:properties:linaro,optee-channel-id: 'oneOf' conditional failed, one must be fixed:
    '$ref' is a required property
    'allOf' is a required property
    hint: A vendor property needs a $ref to types.yaml
    from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
    hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
    from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
    /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/arm,scmi.yaml: ignoring, error in schema: patternProperties: ^protocol@[0-9a-f]+$: properties: linaro,optee-channel-id
    warning: no schema found in file: ./Documentation/devicetree/bindings/firmware/arm,scmi.yaml
    Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml:0:0: /example-1/firmware/scmi: failed to match any schema with compatible: ['arm,scmi']
    Documentation/devicetree/bindings/firmware/arm,scmi.example.dts:175.39-178.19: ERROR (duplicate_label): /example-2/firmware/scmi/protocol@14: Duplicate label 'scmi_clk' on /example-2/firmware/scmi/protocol@14 and /example-0/firmware/scmi/protocol@14
    Documentation/devicetree/bindings/firmware/arm,scmi.example.dts:180.40-186.19: ERROR (duplicate_label): /example-2/firmware/scmi/protocol@13: Duplicate label 'scmi_dvfs' on /example-2/firmware/scmi/protocol@13 and /example-0/firmware/scmi/protocol@13
    ERROR: Input tree has errors, aborting (use -f to force output)
    make[1]: *** [scripts/Makefile.lib:385: Documentation/devicetree/bindings/firmware/arm,scmi.example.dt.yaml] Error 2
    make[1]: *** Waiting for unfinished jobs....
    make: *** [Makefile:1441: dt_binding_check] Error 2

    doc reference errors (make refcheckdocs):

    See https://patchwork.ozlabs.org/patch/1542547

    This check can fail if there are any dependencies. The base for a patch
    series is generally the most recent rc1.

    If you already ran 'make dt_binding_check' and didn't see the above
    error(s), then make sure 'yamllint' is installed and dt-schema is up to
    date:

    pip3 install dtschema --upgrade

    Please check and re-submit.

    \
     
     \ /
      Last update: 2021-10-18 19:33    [W:3.048 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site