Messages in this thread | | | Date | Mon, 18 Oct 2021 19:44:36 +0300 | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCH 1/3] x86/insn-eval: Introduce insn_get_modrm_reg_ptr() |
| |
On Mon, Oct 18, 2021 at 05:47:17PM +0200, Peter Zijlstra wrote: > On Mon, Oct 18, 2021 at 06:33:31PM +0300, Kirill A. Shutemov wrote: > > +/** > > + * insn_get_modrm_reg_ptr() - Obtain register pointer based on ModRM byte > > + * @insn: Instruction containing the ModRM byte > > + * @regs: Register values as seen when entering kernel mode > > + * > > + * Returns: > > + * > > + * The register indicated by the reg part of the ModRM byte. > > + * The register is obtained as a pointer within pt_regs. > > + */ > > +void *insn_get_modrm_reg_ptr(struct insn *insn, struct pt_regs *regs) > > Doesn't that return type want to be 'unsigned long *'?
Right, will fix.
-- Kirill A. Shutemov
| |