Messages in this thread | | | From | "Fabio M. De Francesco" <> | Subject | [PATCH v3 0/3] staging: r8188eu: use completions and clean rtw_cmd_thread() | Date | Mon, 18 Oct 2021 18:20:03 +0200 |
| |
This series replaces two semaphores with three completion variables in rtw_cmd_thread(). Completions variables are better suited for the purposes that are explained in detail in the commit messages of patches 1/3 and 2/3. Furthermore, patch 3/3 removes a redundant 'if' statement from that same rtw_cmd_thread().
Tested with ASUSTek Computer, Inc. Realtek 8188EUS [USB-N10 Nano]
Many thanks to Dan Carpenter <dan.carpenter@oracle.com> who helped with his review of the RFC Patch.
v2 => v3: Patch 1/3: No changes; Patch 2/3: No changes; Patch 3/3: Furher process the commit message according to a review by Greg Kroah-Hartman <gregkh@linuxfoundation.org>>.
v1 => v2: Patch 1/3: No changes; Patch 2/3: Replace wait_for_completion_killable() with wait_for_completion() because killing the kthread is not allowed and so there is no need for killable wait; Patch 3/3: No changes.
Fabio M. De Francesco (3): staging: r8188eu: Use completions for signaling start / end kthread staging: r8188eu: Use completions for signaling enqueueing staging: r8188eu: Remove redundant 'if' statement
drivers/staging/r8188eu/core/rtw_cmd.c | 20 +++++++------------- drivers/staging/r8188eu/include/rtw_cmd.h | 5 +++-- drivers/staging/r8188eu/os_dep/os_intfs.c | 8 +++++--- 3 files changed, 15 insertions(+), 18 deletions(-)
-- 2.33.0
| |