Messages in this thread | | | Date | Mon, 18 Oct 2021 17:47:17 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 1/3] x86/insn-eval: Introduce insn_get_modrm_reg_ptr() |
| |
On Mon, Oct 18, 2021 at 06:33:31PM +0300, Kirill A. Shutemov wrote: > +/** > + * insn_get_modrm_reg_ptr() - Obtain register pointer based on ModRM byte > + * @insn: Instruction containing the ModRM byte > + * @regs: Register values as seen when entering kernel mode > + * > + * Returns: > + * > + * The register indicated by the reg part of the ModRM byte. > + * The register is obtained as a pointer within pt_regs. > + */ > +void *insn_get_modrm_reg_ptr(struct insn *insn, struct pt_regs *regs)
Doesn't that return type want to be 'unsigned long *'?
> +{ > + int offset; > + > + offset = insn_get_modrm_reg_off(insn, regs); > + if (offset < 0) > + return NULL; > + return (void *)regs + offset; > +} > + > /** > * get_seg_base_limit() - obtain base address and limit of a segment > * @insn: Instruction. Must be valid. > -- > 2.32.0 >
| |