lkml.org 
[lkml]   [2021]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mmc: winbond: don't build on M68K
From
Date
On 10/17/21 12:31 PM, Randy Dunlap wrote:
> On 10/17/21 12:20 PM, Arnd Bergmann wrote:
>> On Sun, Oct 17, 2021 at 7:59 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>>>
>>> The Winbond MMC driver fails to build on ARCH=m68k so prevent
>>> that build config. Silences these build errors:
>>>
>>> ../drivers/mmc/host/wbsd.c: In function 'wbsd_request_end':
>>> ../drivers/mmc/host/wbsd.c:212:28: error: implicit declaration of function 'claim_dma_lock' [-Werror=implicit-function-declaration]
>>>    212 |                 dmaflags = claim_dma_lock();
>>> ../drivers/mmc/host/wbsd.c:215:17: error: implicit declaration of function 'release_dma_lock'; did you mean 'release_task'? [-Werror=implicit-function-declaration]
>>>    215 |                 release_dma_lock(dmaflags);
>>>
>>
>> It looks like m68k and sparc declare this function in asm/floppy.h,
>> while everyone
>> else has it in asm/dma.h.
>>
>> Not sure if it's worth fixing in a better way, but I suspect sparc
>> would have the
>> same issue here.
>
> Ah, I should have seen that.
> I'll look into a different patch.
>
> thanks.


OK, I have spent several hours on moving dma functions from floppy.h
to dma.h (for m68k), and it fixes a few things, but there are still
quite a few problems, and I don't see any end in sight (it's either
a maze of twisty tunnels or a twisty maze of tunnels), and it's just
not worth spending more time on it IMO.

--
~Randy

\
 
 \ /
  Last update: 2021-10-18 06:19    [W:0.043 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site