Messages in this thread | | | Date | Mon, 18 Oct 2021 17:12:31 +0200 | From | Greg KH <> | Subject | Re: [PATCH] staging: vt6655: Fix line wrapping in rf.c file |
| |
On Mon, Oct 18, 2021 at 04:05:26PM +0100, Karolina Drobnik wrote: > Fix line length warnings raised by checkpatch.pl in > rf.c file for `RFvWriteWakeProgSyn`,`RFbRawSetPower` > and `RFbAL7230SelectChannelPostProcess`functions. > > Signed-off-by: Karolina Drobnik <karolinadrobnik@gmail.com> > --- > drivers/staging/vt6655/rf.c | 66 +++++++++++++++++++++++++++---------- > 1 file changed, 49 insertions(+), 17 deletions(-) > > diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c > index a6f17162d017..206d34b555bc 100644 > --- a/drivers/staging/vt6655/rf.c > +++ b/drivers/staging/vt6655/rf.c > @@ -699,11 +699,17 @@ bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned char byRFType, > return false; > > for (ii = 0; ii < CB_AL2230_INIT_SEQ; ii++) > - MACvSetMISCFifo(priv, (unsigned short)(MISCFIFO_SYNDATA_IDX + ii), dwAL2230InitTable[ii]); > + MACvSetMISCFifo(priv, > + (unsigned short)(MISCFIFO_SYNDATA_IDX + ii), > + dwAL2230InitTable[ii]); > > - MACvSetMISCFifo(priv, (unsigned short)(MISCFIFO_SYNDATA_IDX + ii), dwAL2230ChannelTable0[uChannel - 1]); > + MACvSetMISCFifo(priv, > + (unsigned short)(MISCFIFO_SYNDATA_IDX + ii), > + dwAL2230ChannelTable0[uChannel - 1]); > ii++; > - MACvSetMISCFifo(priv, (unsigned short)(MISCFIFO_SYNDATA_IDX + ii), dwAL2230ChannelTable1[uChannel - 1]); > + MACvSetMISCFifo(priv, > + (unsigned short)(MISCFIFO_SYNDATA_IDX + ii), > + dwAL2230ChannelTable1[uChannel - 1]); > break; > > /* Need to check, PLLON need to be low for channel setting */ > @@ -716,17 +722,28 @@ bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned char byRFType, > > if (uChannel <= CB_MAX_CHANNEL_24G) { > for (ii = 0; ii < CB_AL7230_INIT_SEQ; ii++) > - MACvSetMISCFifo(priv, (unsigned short)(MISCFIFO_SYNDATA_IDX + ii), dwAL7230InitTable[ii]); > + MACvSetMISCFifo(priv, > + (unsigned short)(MISCFIFO_SYNDATA_IDX > + + ii), dwAL7230InitTable[ii]);
You shouldn't put the "+" on the start of a new line.
Also, these are all just fine as-is for now. A better way to make these lines smaller is to use better variable and function names that are shorter and make sense :)
thanks,
greg k-h
| |