lkml.org 
[lkml]   [2021]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 111/151] net: dsa: fix spurious error message when unoffloaded port leaves bridge
    Date
    From: Alvin Šipraga <alsi@bang-olufsen.dk>

    commit 43a4b4dbd48c9006ef64df3a12acf33bdfe11c61 upstream.

    Flip the sign of a return value check, thereby suppressing the following
    spurious error:

    port 2 failed to notify DSA_NOTIFIER_BRIDGE_LEAVE: -EOPNOTSUPP

    ... which is emitted when removing an unoffloaded DSA switch port from a
    bridge.

    Fixes: d371b7c92d19 ("net: dsa: Unset vlan_filtering when ports leave the bridge")
    Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
    Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Link: https://lore.kernel.org/r/20211012112730.3429157-1-alvin@pqrs.dk
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/dsa/switch.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/dsa/switch.c
    +++ b/net/dsa/switch.c
    @@ -148,7 +148,7 @@ static int dsa_switch_bridge_leave(struc
    if (extack._msg)
    dev_err(ds->dev, "port %d: %s\n", info->port,
    extack._msg);
    - if (err && err != EOPNOTSUPP)
    + if (err && err != -EOPNOTSUPP)
    return err;
    }
    return 0;

    \
     
     \ /
      Last update: 2021-10-18 16:04    [W:6.815 / U:0.692 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site