lkml.org 
[lkml]   [2021]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 129/151] drm/msm/submit: fix overflow check on 64-bit architectures
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    commit 95c58291ee709424557996891926a05a32c5b13a upstream.

    The overflow check does causes a warning from clang-14 when 'sz' is a type
    that is smaller than size_t:

    drivers/gpu/drm/msm/msm_gem_submit.c:217:10: error: result of comparison of constant 18446744073709551615 with expression of type 'unsigned int' is always false [-Werror,-Wtautological-constant-out-of-range-compare]
    if (sz == SIZE_MAX) {

    Change the type accordingly.

    Fixes: 20224d715a88 ("drm/msm/submit: Move copy_from_user ahead of locking bos")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    Reviewed-by: Stephen Boyd <swboyd@chromium.org>
    Link: https://lore.kernel.org/r/20210927113632.3849987-1-arnd@kernel.org
    Signed-off-by: Rob Clark <robdclark@chromium.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpu/drm/msm/msm_gem_submit.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/gpu/drm/msm/msm_gem_submit.c
    +++ b/drivers/gpu/drm/msm/msm_gem_submit.c
    @@ -161,7 +161,8 @@ out:
    static int submit_lookup_cmds(struct msm_gem_submit *submit,
    struct drm_msm_gem_submit *args, struct drm_file *file)
    {
    - unsigned i, sz;
    + unsigned i;
    + size_t sz;
    int ret = 0;

    for (i = 0; i < args->nr_cmds; i++) {

    \
     
     \ /
      Last update: 2021-10-18 16:04    [W:4.140 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site